SVGUseFrame.cpp: namespace alias decl 'SVGT' is unused
Categories
(Core :: SVG, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox84 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: sunitacool41)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(1 file, 3 obsolete files)
Filling as a good first bug to learn workflows.
These line seems to be unused:
https://searchfox.org/mozilla-central/source/layout/svg/SVGUseFrame.cpp#17
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by clang tidy http://clang.llvm.org/extra/clang-tidy/checks/misc-unused-alias-decls.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
Comment 1•5 years ago
|
||
The include of SVGGeometryProperty.h is not required either.
Updated•5 years ago
|
Updated•5 years ago
|
Reporter | ||
Comment 3•5 years ago
|
||
Please propose a patch, the bug will be automatically assigned to you!
Comment 5•5 years ago
|
||
I would like to Work on this issue @Sylvestre. I will make a proposal ASAP
Thanks :)
Comment 6•5 years ago
|
||
Updated•5 years ago
|
Comment 7•5 years ago
|
||
I made a PR but its in revision mode. Kindly Look after it. Thanks :) (In reply to Sylvestre Ledru [:Sylvestre] from comment #4)
Unassigned as no progress for a week.
Comment 8•5 years ago
|
||
(In reply to dhairyabahl5 from comment #7)
I made a PR but its in revision mode. Kindly Look after it. Thanks :) (In reply to Sylvestre Ledru [:Sylvestre] from comment #4)
Unassigned as no progress for a week.
If you make the change, run hg commit --amend to add it to your commit and then run arc diff again, that will update it and I'll re-review.
Comment 9•5 years ago
|
||
(In reply to Robert Longson [:longsonr] from comment #8)
(In reply to dhairyabahl5 from comment #7)
I made a PR but its in revision mode. Kindly Look after it. Thanks :) (In reply to Sylvestre Ledru [:Sylvestre] from comment #4)
Unassigned as no progress for a week.
If you make the change, run hg commit --amend to add it to your commit and then run arc diff again, that will update it and I'll re-review.
Okay, No problem. I am making the required changes. Thanks :)
Comment 10•5 years ago
|
||
Comment 11•5 years ago
|
||
Reporter | ||
Comment 12•5 years ago
|
||
Available for someone else now :)
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 13•5 years ago
|
||
Hello,
I would like to work on this issue :)
Assignee | ||
Comment 14•5 years ago
|
||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 15•5 years ago
|
||
Comment 16•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Description
•