Closed Bug 1669027 Opened 5 years ago Closed 5 years ago

SVGUseFrame.cpp: namespace alias decl 'SVGT' is unused

Categories

(Core :: SVG, task)

task

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: Sylvestre, Assigned: sunitacool41)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file, 3 obsolete files)

Filling as a good first bug to learn workflows.

These line seems to be unused:
https://searchfox.org/mozilla-central/source/layout/svg/SVGUseFrame.cpp#17

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by clang tidy http://clang.llvm.org/extra/clang-tidy/checks/misc-unused-alias-decls.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

The include of SVGGeometryProperty.h is not required either.

Can you please assign this ticket to me?

Flags: needinfo?(sledru)
Assignee: nobody → pctopgs
Flags: needinfo?(sledru)

Please propose a patch, the bug will be automatically assigned to you!

Unassigned as no progress for a week.

Assignee: pctopgs → nobody

I would like to Work on this issue @Sylvestre. I will make a proposal ASAP

Thanks :)

Assignee: nobody → dhairyabahl5
Status: NEW → ASSIGNED

I made a PR but its in revision mode. Kindly Look after it. Thanks :) (In reply to Sylvestre Ledru [:Sylvestre] from comment #4)

Unassigned as no progress for a week.

(In reply to dhairyabahl5 from comment #7)

I made a PR but its in revision mode. Kindly Look after it. Thanks :) (In reply to Sylvestre Ledru [:Sylvestre] from comment #4)

Unassigned as no progress for a week.

If you make the change, run hg commit --amend to add it to your commit and then run arc diff again, that will update it and I'll re-review.

(In reply to Robert Longson [:longsonr] from comment #8)

(In reply to dhairyabahl5 from comment #7)

I made a PR but its in revision mode. Kindly Look after it. Thanks :) (In reply to Sylvestre Ledru [:Sylvestre] from comment #4)

Unassigned as no progress for a week.

If you make the change, run hg commit --amend to add it to your commit and then run arc diff again, that will update it and I'll re-review.

Okay, No problem. I am making the required changes. Thanks :)

Available for someone else now :)

Assignee: dhairyabahl5 → nobody
Status: ASSIGNED → NEW
Assignee: nobody → dhairyabahl5
Status: NEW → ASSIGNED
Assignee: dhairyabahl5 → nobody
Status: ASSIGNED → NEW

Hello,
I would like to work on this issue :)

Assignee: nobody → sunitacool41
Status: NEW → ASSIGNED
Attachment #9186912 - Attachment description: Bug 1669027 - SVGUseFrame.cpp: namespace alias decl 'SVGT' is unused. r = Sylvestre → Bug 1669027 - SVGUseFrame.cpp: namespace alias decl 'SVGT' is unused
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c45abeda2ab4 SVGUseFrame.cpp: namespace alias decl 'SVGT' is unused r=longsonr
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
Attachment #9181605 - Attachment is obsolete: true
Attachment #9181541 - Attachment is obsolete: true
Attachment #9181479 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: